Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
F13205159: D17282.diff
Wed, May 15, 1:29 AM
F13189475: D17282.diff
Sat, May 11, 6:05 AM
Unknown Object (File)
Sat, May 4, 12:22 PM
Unknown Object (File)
Sat, May 4, 12:18 PM
Unknown Object (File)
Sat, May 4, 12:18 PM
Unknown Object (File)
Sat, May 4, 12:18 PM
Unknown Object (File)
Sat, May 4, 12:09 PM
Unknown Object (File)
Fri, May 3, 1:33 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable