Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
F15413455: D17282.id41575.diff
Wed, Mar 19, 6:51 PM
F15406716: D17282.id41576.diff
Tue, Mar 18, 1:30 PM
F15400044: D17282.id41574.diff
Mon, Mar 17, 9:20 AM
F15387044: D17282.id41574.diff
Sat, Mar 15, 1:43 AM
F15364499: D17282.diff
Tue, Mar 11, 1:37 PM
F15338590: D17282.diff
Sun, Mar 9, 11:37 AM
Unknown Object (File)
Tue, Feb 25, 8:19 AM
Unknown Object (File)
Tue, Feb 25, 12:02 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Branch
buildkite2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15473
Build 20392: Run Core Tests
Build 20391: arc lint + arc unit