Page MenuHomePhabricator

Navigage Buildkite builds with more nuance
ClosedPublic

Authored by epriestley on Jan 31 2017, 11:34 PM.
Tags
None
Referenced Files
F15461349: D17282.id41574.diff
Tue, Apr 1, 7:43 AM
F15460955: D17282.id41575.diff
Tue, Apr 1, 3:43 AM
F15458921: D17282.id.diff
Mon, Mar 31, 8:17 AM
F15442593: D17282.id41576.diff
Wed, Mar 26, 11:49 PM
F15442592: D17282.id.diff
Wed, Mar 26, 11:49 PM
F15441448: D17282.id41574.diff
Wed, Mar 26, 6:17 PM
F15438163: D17282.diff
Tue, Mar 25, 11:38 PM
F15433064: D17282.id41574.diff
Mon, Mar 24, 9:11 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T12173.

  • If we want to fetch a tag, Buildkite needs it as a "branch" (this means more like "ref to fetch").
  • The API gets upset if we pass "refs/tags/...", so just pass the tag name without the prefix, which works.
  • Do a better job with commits and pass a real branch to fetch.
Test Plan
  • Built a commit with Buildkite.
  • Build a revision with Buildkite.

Diff Detail

Repository
rP Phabricator
Branch
buildkite2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15472
Build 20390: Run Core Tests
Build 20389: arc lint + arc unit