Page MenuHomePhabricator

Fix a couple of home menu issues for logged-out viewers
ClosedPublic

Authored by epriestley on Jan 31 2017, 7:38 PM.
Tags
None
Referenced Files
F14085433: D17274.diff
Sat, Nov 23, 11:58 AM
F14082779: D17274.diff
Sat, Nov 23, 1:19 AM
Unknown Object (File)
Mon, Nov 18, 8:23 PM
Unknown Object (File)
Sat, Nov 9, 12:52 PM
Unknown Object (File)
Wed, Oct 30, 7:32 PM
Unknown Object (File)
Oct 22 2024, 11:17 PM
Unknown Object (File)
Oct 21 2024, 8:14 PM
Unknown Object (File)
Oct 21 2024, 5:35 PM
Subscribers
None

Details

Summary

Ref T12174. These items could fatal ($item not defined) if the viewer was not logged in.

Test Plan
  • Viewed home as a logged-out user.

Diff Detail

Repository
rP Phabricator
Branch
home3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15456
Build 20366: Run Core Tests
Build 20365: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 31 2017, 7:40 PM
src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php
51–59

oops this should be ! hue hue

I didn't think to check logged out homepage.

Actually, I guesss "More Applications" is fine to show whether the user is logged in or not.

  • Show "More Applications" even if the user is not logged in, it's fine for them to go explore Paste or whatever.
This revision was automatically updated to reflect the committed changes.

What's the plan with mobile

I liked the old behavior (show menu by default). I don't think this behavior (show default item by default) is awful if you want to keep it, but I'd plan to swap back to the old behavior unless you particularly like this one.

I prefer the menu, mostly because I use Feed more on mobile.