HomePhabricator

Replace ProfileMenu bugs with different bugs

Authored by epriestley on Jan 31 2017, 6:48 PM.

Description

Replace ProfileMenu bugs with different bugs

Summary:
Ref T12174. This fixes more bugs than it creates, I think:

  • Dashboards now show the whole menu.
  • Project and home items now show selected state correctly.
  • The "choose global vs personal" thing is now part of MenuEngine, and the same code builds it for Home and Favorites.
  • Home now handles defaults correctly, I think.

Maybe regression/bad/still buggy?:

  • Mobile home is now whatever the default thing was, not the menu?
  • Title for dashboard content or other items that render their own content is incorrectly always "Configure Menu" (this was preexisting).

Test Plan:

  • Created, edited, reordered, disabled, deleted and pinned personal and global items on home, favorites, and projects.
  • Also checked User profiles.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17273

Details

Committed
epriestleyJan 31 2017, 7:22 PM
Pushed
epriestleyJan 31 2017, 7:22 PM
Reviewer
chad
Differential Revision
D17273: Replace ProfileMenu bugs with different bugs
Parents
rPbd99a2b81ea5: Integrate Harbormaster with Buildkite
Branches
Unknown
Tags
Unknown
Tasks
T12174: Home Menu Errata
Build Status
Buildable 15454
Build 20362: Run Core Tests