Ref T12174. These items could fatal ($item not defined) if the viewer was not logged in.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T12174: Home Menu Errata
- Commits
- rP27a33896ff1c: Fix a couple of home menu issues for logged-out viewers
- Viewed home as a logged-out user.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- home3
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15455 Build 20364: Run Core Tests Build 20363: arc lint + arc unit
Event Timeline
| src/applications/home/menuitem/PhabricatorHomeLauncherProfileMenuItem.php | ||
|---|---|---|
| 52–54 | oops this should be ! hue hue | |
Comment Actions
Actually, I guesss "More Applications" is fine to show whether the user is logged in or not.
Comment Actions
- Show "More Applications" even if the user is not logged in, it's fine for them to go explore Paste or whatever.
Comment Actions
I liked the old behavior (show menu by default). I don't think this behavior (show default item by default) is awful if you want to keep it, but I'd plan to swap back to the old behavior unless you particularly like this one.