Improve `ArcanistDeprecationXHPASTLinterRule` by lowercasing keys in `xhpast.deprecated.functions`
Needs ReviewPublic
Actions

Authored by thaiphv on Jan 19 2017, 10:35 PM.

Details

Reviewers

joshuaspence

Group Reviewers

Blessed Reviewers

Summary

As titled, this diff improves the linter by lowercasing all the blacklisted function/method names configured in xhpast.deprecated.functions. This change allows us to declare the blacklisted items in their original case, just for look and feel purpose.

Test Plan

Run arc unit.

Diff Detail

Repository

rARC Arcanist

Branch

thai-fix-ArcanistDeprecationXHPASTLinterRule

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15352
Build 20213: arc lint + arc unit

Event Timeline

thaiphv created this revision.Jan 19 2017, 10:35 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 19 2017, 10:35 PM

Herald added a subscriber: epriestley. · View Herald Transcript

I think you probably want to use CaseInsensitiveArray, otherwise the linter message won't exactly match xhpast.deprecated.functions.

This revision now requires changes to proceed.Jan 19 2017, 10:38 PM

Use CaseInsensitiveArray to store xhpast.deprecated.functions
Fix jshint.lint-test

joshuaspence accepted this revision.Feb 10 2017, 2:45 AM

joshuaspence added inline comments.

src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php
40–41	We should probably modify the `getFunctionCalls` method to do this.
src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-function.lint-test
3–4	Maybe also add a function call that uses the same casing? DeprecatedFunction();