As titled, this diff improves the linter by lowercasing all the blacklisted function/method names configured in xhpast.deprecated.functions. This change allows us to declare the blacklisted items in their original case, just for look and feel purpose.
Details
Details
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- thai-update-ArcanistDeprecationXHPASTLinterRule
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 15334 Build 20187: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 1,593 ms | ArcanistJSHintLinterTestCase::Unknown Unit Message (" ") In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised:
warning at line 3, char 8: W033 JSHintW033
error at line 7, char 1: E019 JSHintE019
| |
| 201 ms | ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message (" ") 7 assertions passed. | |
| 76 ms | ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message (" ") 3 assertions passed. | |
| 81 ms | ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message (" ") 4 assertions passed. | |
| 74 ms | ArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message (" ") 3 assertions passed. | |
| View Full Test Results (1 Failed · 123 Passed · 29 Skipped) |
Event Timeline
Comment Actions
I think you probably want to use CaseInsensitiveArray, otherwise the linter message won't exactly match xhpast.deprecated.functions.
| src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php | ||
|---|---|---|
| 45–46 | We should probably modify the getFunctionCalls method to do this. | |
| src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-function.lint-test | ||
| 3–4 | Maybe also add a function call that uses the same casing? DeprecatedFunction(); | |