Differential D17184

Order inline comments in Diffusion consistently with Differential
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 10:46 PM.

Details

Reviewers

chad

Maniphest Tasks

T8739: Inline comments not sorted

Commits

rPb471f6c07aef: Order inline comments in Diffusion consistently with Differential

Summary

Fixes T8739. Currently, Diffusion inline comments in the timeline are sorted arbitrarily, mostly by creation order.

Instead, sort them by line number, like Differential.

Test Plan

Made comments in "C", "B", "A" order, saw them in line order after submit:

Screen Shot 2017-01-11 at 2.44.08 PM.png (271×504 px, 36 KB)

Diff Detail

Repository

rP Phabricator

Branch

commit9

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/audit/view/PhabricatorAuditTransactionView.php:88	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 15211
Build 19992: Run Core Tests
Build 19991: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 11 2017, 10:46 PM

Harbormaster completed remote builds in B15211: Diff 41324.Jan 11 2017, 10:47 PM

chad accepted this revision.Jan 11 2017, 10:56 PM

This revision is now accepted and ready to land.Jan 11 2017, 10:56 PM

Closed by commit rPb471f6c07aef: Order inline comments in Diffusion consistently with Differential (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2017, 10:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

view/

PhabricatorAuditTransactionView.php

82 lines

Diff 41324

View Options

src/applications/audit/view/PhabricatorAuditTransactionView.php

Order inline comments in Diffusion consistently with DifferentialClosedPublicActions