Page MenuHomePhabricator

Be more lenient when accepting "Differential Revision" in the presence of custom ad-hoc commit message fields
ClosedPublic

Authored by epriestley on Jan 1 2017, 4:10 PM.
Tags
None
Referenced Files
F15333450: D17121.id41178.diff
Sat, Mar 8, 2:23 AM
Unknown Object (File)
Tue, Feb 18, 12:16 PM
Unknown Object (File)
Tue, Feb 11, 3:59 AM
Unknown Object (File)
Feb 6 2025, 1:03 AM
Unknown Object (File)
Jan 27 2025, 4:47 AM
Unknown Object (File)
Jan 27 2025, 4:47 AM
Unknown Object (File)
Jan 27 2025, 4:47 AM
Unknown Object (File)
Jan 24 2025, 8:33 AM
Subscribers
None

Details

Summary

Fixes T8360. We will now parse revisions out of "Differential Revision: X" followed by other ad-hoc fields which we do not recognize. Previously, these fields would be treated as part of the value.

(In the general case, other fields may line wrap so we can't assume that fields are only one line long. However, we can make that assumption safely for this field.)

Also maybe fix whatever was going on in T9965 although that didn't really have a reproduction case.

Test Plan

Added unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable