Page MenuHomePhabricator

Be more lenient when accepting "Differential Revision" in the presence of custom ad-hoc commit message fields
ClosedPublic

Authored by epriestley on Jan 1 2017, 4:10 PM.
Tags
None
Referenced Files
F18812273: D17121.diff
Mon, Oct 20, 8:05 AM
F18624041: D17121.id41184.diff
Sep 15 2025, 6:31 PM
F18566020: D17121.id.diff
Sep 9 2025, 2:14 PM
F18500406: D17121.diff
Sep 4 2025, 9:03 PM
F18457062: D17121.id41178.diff
Sep 1 2025, 12:06 PM
F18456543: D17121.id.diff
Sep 1 2025, 11:10 AM
F18456313: D17121.diff
Sep 1 2025, 10:42 AM
F17953988: D17121.id41178.diff
Aug 1 2025, 3:39 AM
Subscribers
None

Details

Summary

Fixes T8360. We will now parse revisions out of "Differential Revision: X" followed by other ad-hoc fields which we do not recognize. Previously, these fields would be treated as part of the value.

(In the general case, other fields may line wrap so we can't assume that fields are only one line long. However, we can make that assumption safely for this field.)

Also maybe fix whatever was going on in T9965 although that didn't really have a reproduction case.

Test Plan

Added unit tests.

Diff Detail

Repository
rP Phabricator
Branch
parse1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15066
Build 19771: Run Core Tests
Build 19770: arc lint + arc unit