Page MenuHomePhabricator

Restore "Commandeer" action to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 10:37 PM.
Tags
None
Referenced Files
F14363096: D17111.id41150.diff
Fri, Dec 20, 1:48 PM
Unknown Object (File)
Thu, Dec 5, 1:45 AM
Unknown Object (File)
Wed, Nov 27, 2:19 PM
Unknown Object (File)
Sat, Nov 23, 11:29 AM
Unknown Object (File)
Sat, Nov 23, 9:42 AM
Unknown Object (File)
Nov 19 2024, 1:31 AM
Unknown Object (File)
Nov 14 2024, 6:05 PM
Unknown Object (File)
Nov 11 2024, 4:07 AM
Subscribers
None

Details

Summary

Ref T11114. This has two pieces of side-effect logic which I've noted locally:

  • Commandeer needs to apply Herald rules.
  • Commandeer needs to move the old author to become a reviewer and remove the actor as a reviewer.
Test Plan

Commandeered some revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15037
Build 19731: Run Core Tests
Build 19730: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.