Page MenuHomePhabricator

Restore "Commandeer" action to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 10:37 PM.
Tags
None
Referenced Files
F19188518: D17111.diff
Dec 16 2025, 7:29 AM
F18881996: D17111.id.diff
Nov 6 2025, 10:19 PM
F18876849: D17111.id41169.diff
Nov 6 2025, 4:22 AM
F18875941: D17111.diff
Nov 5 2025, 8:35 PM
F18833652: D17111.diff
Oct 26 2025, 5:05 AM
F18763346: D17111.id.diff
Oct 6 2025, 11:52 PM
F18757974: D17111.diff
Oct 5 2025, 8:16 PM
F18631244: D17111.diff
Sep 16 2025, 2:49 PM
Subscribers
None

Details

Summary

Ref T11114. This has two pieces of side-effect logic which I've noted locally:

  • Commandeer needs to apply Herald rules.
  • Commandeer needs to move the old author to become a reviewer and remove the actor as a reviewer.
Test Plan

Commandeered some revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15037
Build 19731: Run Core Tests
Build 19730: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.