Restore "Commandeer" action to Differential on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 28 2016, 10:37 PM.

Tags

None

Referenced Files

	F13172106: D17111.diff
	Tue, May 7, 1:35 PM

	F13168865: D17111.diff
	Tue, May 7, 7:59 AM

	Unknown Object (File)
	Mon, May 6, 1:51 PM

	Unknown Object (File)
	Fri, May 3, 7:44 AM

	Unknown Object (File)
	Thu, May 2, 9:30 AM

	Unknown Object (File)
	Mon, Apr 29, 11:05 PM

	Unknown Object (File)
	Sun, Apr 28, 11:57 AM

	Unknown Object (File)
	Thu, Apr 25, 1:42 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T11114: Move Differential to EditEngine

Commits

rP8b74cd481a47: Restore "Commandeer" action to Differential on EditEngine

Summary

Ref T11114. This has two pieces of side-effect logic which I've noted locally:

Commandeer needs to apply Herald rules.
Commandeer needs to move the old author to become a reviewer and remove the actor as a reviewer.

Test Plan

Commandeered some revisions.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 28 2016, 10:37 PM

chad accepted this revision.Dec 29 2016, 6:57 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 29 2016, 6:57 PM

Closed by commit rP8b74cd481a47: Restore "Commandeer" action to Differential on EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

xaction/

DifferentialRevisionCommandeerTransaction.php

67 lines

Diff 41169

View Options

src/__phutil_library_map__.php