Page MenuHomePhabricator

Restore "Commandeer" action to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 10:37 PM.
Tags
None
Referenced Files
F15534006: D17111.diff
Wed, Apr 23, 10:49 PM
F15508312: D17111.id41169.diff
Wed, Apr 16, 4:35 AM
F15506730: D17111.id41150.diff
Tue, Apr 15, 1:44 PM
F15453471: D17111.id41169.diff
Sat, Mar 29, 12:05 PM
F15447468: D17111.id.diff
Fri, Mar 28, 12:02 AM
F15442341: D17111.diff
Mar 26 2025, 10:52 PM
F15390671: D17111.id.diff
Mar 15 2025, 6:25 AM
Unknown Object (File)
Mar 3 2025, 3:39 PM
Subscribers
None

Details

Summary

Ref T11114. This has two pieces of side-effect logic which I've noted locally:

  • Commandeer needs to apply Herald rules.
  • Commandeer needs to move the old author to become a reviewer and remove the actor as a reviewer.
Test Plan

Commandeered some revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15037
Build 19731: Run Core Tests
Build 19730: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.