Page MenuHomePhabricator

Restore "Close" and "Reopen" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 9:23 PM.
Tags
None
Referenced Files
F19821676: D17108.diff
Fri, Mar 6, 11:50 PM
F19811292: D17108.id41167.diff
Tue, Mar 3, 11:39 PM
F19575768: D17108.id41167.diff
Feb 1 2026, 7:54 AM
F19520668: D17108.diff
Jan 16 2026, 3:31 PM
F19520667: D17108.diff
Jan 16 2026, 3:31 PM
F19322498: D17108.id.diff
Dec 25 2025, 11:15 AM
F19304070: D17108.id41147.diff
Dec 24 2025, 7:03 AM
F19041555: D17108.diff
Nov 26 2025, 4:00 PM
Subscribers
None

Details

Summary

Ref T11114. This restores these actions as selectable in the comment area.

This does not implement one special rule ("Closing a revision in response to a commit is OK from any status.") but I have a note about that separately.

Test Plan

Closed and reopened revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15034
Build 19725: Run Core Tests
Build 19724: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:51 PM
This revision was automatically updated to reflect the committed changes.