Page MenuHomePhabricator
Differential D17108

Restore "Close" and "Reopen" actions to Differential on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 28 2016, 9:23 PM.

Details

Reviewers
chad
Maniphest Tasks
T11114: Move Differential to EditEngine
Commits
rPa90ab7f4033d: Restore "Close" and "Reopen" actions to Differential on EditEngine
Summary

Ref T11114. This restores these actions as selectable in the comment area.

This does not implement one special rule ("Closing a revision in response to a commit is OK from any status.") but I have a note about that separately.

Test Plan

Closed and reopened revisions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 28 2016, 9:23 PM
chad accepted this revision.Dec 29 2016, 5:51 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:51 PM
Closed by commit rPa90ab7f4033d: Restore "Close" and "Reopen" actions to Differential on EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41167

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php

Loading...
Phabricator · Built by Phacility