Page MenuHomePhabricator

Restore "Close" and "Reopen" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 9:23 PM.
Tags
None
Referenced Files
F17885639: D17108.id41147.diff
Tue, Jul 29, 12:28 AM
F17875801: D17108.diff
Mon, Jul 28, 6:37 PM
F17861425: D17108.id41167.diff
Sun, Jul 27, 10:48 PM
F17844521: D17108.id.diff
Sun, Jul 27, 2:14 AM
F17843697: D17108.id41167.diff
Sun, Jul 27, 1:15 AM
F17823317: D17108.diff
Sat, Jul 26, 4:31 AM
Unknown Object (File)
Jun 29 2025, 3:36 PM
Unknown Object (File)
Jun 28 2025, 5:25 PM
Subscribers
None

Details

Summary

Ref T11114. This restores these actions as selectable in the comment area.

This does not implement one special rule ("Closing a revision in response to a commit is OK from any status.") but I have a note about that separately.

Test Plan

Closed and reopened revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15034
Build 19725: Run Core Tests
Build 19724: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:51 PM
This revision was automatically updated to reflect the committed changes.