Page MenuHomePhabricator

Restore "Close" and "Reopen" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 9:23 PM.
Tags
None
Referenced Files
F14440536: D17108.diff
Thu, Dec 26, 5:31 AM
Unknown Object (File)
Wed, Dec 11, 1:17 AM
Unknown Object (File)
Tue, Dec 10, 1:28 AM
Unknown Object (File)
Wed, Nov 27, 3:02 AM
Unknown Object (File)
Nov 23 2024, 7:26 AM
Unknown Object (File)
Nov 19 2024, 3:02 PM
Unknown Object (File)
Nov 15 2024, 3:14 PM
Unknown Object (File)
Nov 11 2024, 11:31 AM
Subscribers
None

Details

Summary

Ref T11114. This restores these actions as selectable in the comment area.

This does not implement one special rule ("Closing a revision in response to a commit is OK from any status.") but I have a note about that separately.

Test Plan

Closed and reopened revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15034
Build 19725: Run Core Tests
Build 19724: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:51 PM
This revision was automatically updated to reflect the committed changes.