Page MenuHomePhabricator

Restore "Close" and "Reopen" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 9:23 PM.
Tags
None
Referenced Files
F15462738: D17108.id41147.diff
Tue, Apr 1, 5:16 PM
F15445718: D17108.id.diff
Thu, Mar 27, 3:39 PM
F15441426: D17108.diff
Wed, Mar 26, 6:09 PM
F15418689: D17108.id41167.diff
Fri, Mar 21, 12:53 AM
F15414216: D17108.id.diff
Wed, Mar 19, 11:27 PM
F15298433: D17108.id.diff
Mar 5 2025, 1:20 PM
Unknown Object (File)
Mar 3 2025, 8:43 PM
Unknown Object (File)
Feb 22 2025, 1:19 AM
Subscribers
None

Details

Summary

Ref T11114. This restores these actions as selectable in the comment area.

This does not implement one special rule ("Closing a revision in response to a commit is OK from any status.") but I have a note about that separately.

Test Plan

Closed and reopened revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15034
Build 19725: Run Core Tests
Build 19724: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:51 PM
This revision was automatically updated to reflect the committed changes.