Page MenuHomePhabricator

Restore "Close" and "Reopen" actions to Differential on EditEngine
ClosedPublic

Authored by epriestley on Dec 28 2016, 9:23 PM.
Tags
None
Referenced Files
F13162056: D17108.diff
Mon, May 6, 11:40 AM
Unknown Object (File)
Fri, May 3, 5:57 PM
Unknown Object (File)
Fri, May 3, 7:28 AM
Unknown Object (File)
Thu, Apr 25, 1:33 AM
Unknown Object (File)
Fri, Apr 19, 5:58 PM
Unknown Object (File)
Thu, Apr 11, 9:08 AM
Unknown Object (File)
Apr 1 2024, 3:37 AM
Unknown Object (File)
Mar 30 2024, 3:42 AM
Subscribers
None

Details

Summary

Ref T11114. This restores these actions as selectable in the comment area.

This does not implement one special rule ("Closing a revision in response to a commit is OK from any status.") but I have a note about that separately.

Test Plan

Closed and reopened revisions.

Diff Detail

Repository
rP Phabricator
Branch
haunt4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15034
Build 19725: Run Core Tests
Build 19724: arc lint + arc unit

Event Timeline

chad edited edge metadata.
This revision is now accepted and ready to land.Dec 29 2016, 5:51 PM
This revision was automatically updated to reflect the committed changes.