Page MenuHomePhabricator

Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine
ClosedPublic

Authored by epriestley on Dec 16 2016, 1:46 PM.
Tags
None
Referenced Files
F14042370: D17067.diff
Tue, Nov 12, 3:00 AM
F14037544: D17067.diff
Sun, Nov 10, 4:50 PM
F14024606: D17067.diff
Thu, Nov 7, 11:04 AM
F14021916: D17067.id41055.diff
Wed, Nov 6, 1:55 PM
F13997919: D17067.id41055.diff
Thu, Oct 24, 6:48 AM
F13979603: D17067.diff
Sat, Oct 19, 5:22 AM
F13975597: D17067.diff
Fri, Oct 18, 10:53 AM
F13967483: D17067.id41083.diff
Wed, Oct 16, 1:55 PM
Subscribers
None

Details

Summary

Ref T11114. This creates differential.revision.edit (a modern, v3 API method) and redefines the existing methods in terms of it.

Both differential.createrevision and differential.updaterevision are now internally implemented by building a differential.revision.edit API call and then executing it.

I think this covers everything except custom fields, which need some tweaking to work with EditEngine. I'll clean that up in the next change.

Test Plan
  • Created, updated, and edited revisions via arc.
  • Called APIs manually via test console.
  • Stored custom fields ("Blame Rev", "Revert Plan") aren't exposed yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 3:18 PM
This revision was automatically updated to reflect the committed changes.