Page MenuHomePhabricator

Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine
ClosedPublic

Authored by epriestley on Dec 16 2016, 1:46 PM.
Tags
None
Referenced Files
F14105992: D17067.diff
Wed, Nov 27, 4:06 AM
Unknown Object (File)
Sun, Nov 24, 5:03 AM
Unknown Object (File)
Sat, Nov 23, 3:50 PM
Unknown Object (File)
Mon, Nov 18, 9:33 PM
Unknown Object (File)
Fri, Nov 15, 5:09 AM
Unknown Object (File)
Tue, Nov 12, 3:00 AM
Unknown Object (File)
Sun, Nov 10, 4:50 PM
Unknown Object (File)
Thu, Nov 7, 11:04 AM
Subscribers
None

Details

Summary

Ref T11114. This creates differential.revision.edit (a modern, v3 API method) and redefines the existing methods in terms of it.

Both differential.createrevision and differential.updaterevision are now internally implemented by building a differential.revision.edit API call and then executing it.

I think this covers everything except custom fields, which need some tweaking to work with EditEngine. I'll clean that up in the next change.

Test Plan
  • Created, updated, and edited revisions via arc.
  • Called APIs manually via test console.
  • Stored custom fields ("Blame Rev", "Revert Plan") aren't exposed yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2016, 3:18 PM
This revision was automatically updated to reflect the committed changes.