Ref T11114. This probably still has some bugs, but survives basic sanity checks.
Continue pulling commit message logic out of CustomField so we can reduce the amount of responsibility/bloat in the classtree and send more code through EditEngine.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T11114: Move Differential to EditEngine
- Commits
- rP24926f9453e5: Move Differential commit message rendering to dedicated classes
- Called differential.getcommitmessage via API console for various revisions/parameters (edit and create mode, with and without fields, with and without revisions).
- Used --create, --edit and --update modes of arc diff from the CLI.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- diff18
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14943 Build 19584: Run Core Tests Build 19583: arc lint + arc unit
Event Timeline
Comment Actions
I've also removed the "pro tips" in commit message templates since I don't get the sense that anyone ever actually read them. We could restore them later if they are missed.