Page MenuHomePhabricator

Fix an issue with mentioning revisions on the new EditEngine code
ClosedPublic

Authored by epriestley on Dec 14 2016, 10:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 12:07 AM
Unknown Object (File)
Tue, Apr 30, 10:33 PM
Unknown Object (File)
Tue, Apr 30, 3:46 PM
Unknown Object (File)
Fri, Apr 19, 5:53 PM
Unknown Object (File)
Sun, Apr 14, 7:44 AM
Unknown Object (File)
Fri, Apr 12, 10:23 PM
Unknown Object (File)
Thu, Apr 11, 8:59 AM
Unknown Object (File)
Thu, Apr 4, 5:28 AM
Subscribers
None

Details

Summary

Ref T12020. Ref T11114. If we continue here on a mention, we try to generate $old, which requires reviewers to be attached. They won't be for simple codepaths like mentions.

Instead, just bail early: we don't need to do anything anyway since we can't possibly find any more errors with zero transactions.

Test Plan

Mentioned a revision on a task.

Diff Detail

Repository
rP Phabricator
Branch
diff17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14921
Build 19549: Run Core Tests
Build 19548: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an issue with mentioning revisions on the new EditEngine code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
avivey edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2016, 10:02 PM
This revision was automatically updated to reflect the committed changes.