Page MenuHomePhabricator
Differential D16990

Modernize UI for "Compare" in Diffusion
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 1:42 AM.
Tags
None
Referenced Files
F14045325: D16990.id40881.diff
Wed, Nov 13, 2:53 AM
F14024984: D16990.id40881.diff
Thu, Nov 7, 1:47 PM
F14013523: D16990.id40881.diff
Sat, Nov 2, 7:32 AM
F13996238: D16990.id.diff
Wed, Oct 23, 7:15 PM
F13986270: D16990.diff
Mon, Oct 21, 1:42 AM
Unknown Object (File)
Oct 10 2024, 4:15 AM
Unknown Object (File)
Oct 2 2024, 4:27 PM
Unknown Object (File)
Sep 6 2024, 4:56 AM
View All Files
Subscribers
None

Details

Reviewers
avivey
chad
Maniphest Tasks
T929: Allow two arbitrary revisions to be compared in Diffusion
Commits
rPfc1adf987573: Modernize UI for "Compare" in Diffusion
Summary

Ref T929. We've made some UI updates since D15330.

Test Plan

Screen Shot 2016-12-05 at 5.40.28 PM.png (1×1 px, 334 KB)

Diff Detail

Repository
rP Phabricator
Branch
compare1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/controller/DiffusionCompareController.php:271XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14766
Build 19302: Run Core Tests
Build 19301: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40880.Dec 6 2016, 1:42 AM
epriestley retitled this revision from to Modernize UI for "Compare" in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
epriestley added a task: T929: Allow two arbitrary revisions to be compared in Diffusion.
chad accepted this revision.Dec 6 2016, 1:44 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 1:44 AM
Closed by commit rPfc1adf987573: Modernize UI for "Compare" in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 2:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
16 lines
383 lines
request/
2 lines
repository/
storage/
31 lines

Diff 40880

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCompareController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility