Page MenuHomePhabricator

Modernize UI for "Compare" in Diffusion
ClosedPublic

Authored by epriestley on Dec 6 2016, 1:42 AM.
Tags
None
Referenced Files
F12840115: D16990.diff
Thu, Mar 28, 8:12 PM
Unknown Object (File)
Tue, Mar 26, 7:09 PM
Unknown Object (File)
Tue, Mar 26, 7:09 PM
Unknown Object (File)
Tue, Mar 26, 7:09 PM
Unknown Object (File)
Thu, Mar 7, 12:21 AM
Unknown Object (File)
Feb 16 2024, 3:33 AM
Unknown Object (File)
Feb 14 2024, 12:19 AM
Unknown Object (File)
Feb 3 2024, 1:19 PM
Subscribers
None

Details

Summary

Ref T929. We've made some UI updates since D15330.

Test Plan

Screen Shot 2016-12-05 at 5.40.28 PM.png (1×1 px, 334 KB)

Diff Detail

Repository
rP Phabricator
Branch
compare1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/controller/DiffusionCompareController.php:271XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14766
Build 19302: Run Core Tests
Build 19301: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize UI for "Compare" in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 1:44 AM
This revision was automatically updated to reflect the committed changes.