Page MenuHomePhabricator
Differential D16990

Modernize UI for "Compare" in Diffusion
ClosedPublic
Actions

Authored by epriestley on Dec 6 2016, 1:42 AM.
Tags
None
Referenced Files
F13060429: D16990.diff
Fri, Apr 19, 5:49 PM
F13054941: D16990.diff
Fri, Apr 19, 12:20 PM
Unknown Object (File)
Thu, Apr 11, 8:37 AM
Unknown Object (File)
Sat, Apr 6, 2:50 PM
Unknown Object (File)
Wed, Apr 3, 8:10 AM
Unknown Object (File)
Wed, Apr 3, 8:09 AM
Unknown Object (File)
Tue, Apr 2, 10:52 PM
Unknown Object (File)
Tue, Apr 2, 11:30 AM
View All Files
Subscribers
None

Details

Reviewers
avivey
chad
Maniphest Tasks
T929: Allow two arbitrary revisions to be compared in Diffusion
Commits
rPfc1adf987573: Modernize UI for "Compare" in Diffusion
Summary

Ref T929. We've made some UI updates since D15330.

Test Plan

Screen Shot 2016-12-05 at 5.40.28 PM.png (1×1 px, 334 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40880.Dec 6 2016, 1:42 AM
epriestley retitled this revision from to Modernize UI for "Compare" in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
epriestley added a task: T929: Allow two arbitrary revisions to be compared in Diffusion.
chad accepted this revision.Dec 6 2016, 1:44 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2016, 1:44 AM
Closed by commit rPfc1adf987573: Modernize UI for "Compare" in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyDec 6 2016, 2:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
16 lines
383 lines
request/
2 lines
repository/
storage/
31 lines

Diff 40881

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCompareController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility