Page MenuHomePhabricator

Improve typeahead behavior with mixed-case matches
ClosedPublic

Authored by epriestley on Nov 8 2016, 7:40 PM.
Tags
None
Referenced Files
F15461933: D16826.id40518.diff
Tue, Apr 1, 12:26 PM
F15446261: D16826.id40517.diff
Thu, Mar 27, 6:02 PM
F15445686: D16826.id.diff
Thu, Mar 27, 3:29 PM
F15384167: D16826.id40518.diff
Fri, Mar 14, 7:00 PM
F15383980: D16826.diff
Fri, Mar 14, 6:30 PM
F15345822: D16826.id40517.diff
Mar 10 2025, 12:50 PM
F15334282: D16826.diff
Mar 8 2025, 8:01 AM
Unknown Object (File)
Mar 2 2025, 9:18 AM
Subscribers
None

Details

Summary

Ref T8510. We had two issues with mixed-case result sorting, like typing @joe to match user Joe.

  • The fallback sort was not normalized properly, so "J" could sort after "j". Instead, normalize values for sorting.
  • The prefix_hits and older priority_hits mechanisms were competing destructively. The prefix_hits mechanism completely replaces the priority_hits mechanism. Instead, use only the prefix_hits mechanism.
Test Plan
  • Copied results for "joe" from WMF.
  • Hard-coded the controller to return them.
  • Searched for @joe.
  • After patches, first hit is user "Joe".

Diff Detail

Repository
rP Phabricator
Branch
typeahead1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14407
Build 18767: Run Core Tests
Build 18766: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve typeahead behavior with mixed-case matches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 7:41 PM
This revision was automatically updated to reflect the committed changes.