Page MenuHomePhabricator

Improve typeahead behavior with mixed-case matches
ClosedPublic

Authored by epriestley on Nov 8 2016, 7:40 PM.
Tags
None
Referenced Files
F14057787: D16826.diff
Sun, Nov 17, 6:51 AM
F14005531: D16826.id40518.diff
Sun, Oct 27, 2:59 PM
F13980658: D16826.diff
Sat, Oct 19, 11:51 AM
F13979138: D16826.diff
Oct 19 2024, 2:52 AM
F13978564: D16826.id.diff
Oct 18 2024, 11:50 PM
F13969525: D16826.id40517.diff
Oct 17 2024, 2:57 AM
Unknown Object (File)
Oct 2 2024, 11:10 PM
Unknown Object (File)
Oct 2 2024, 11:10 PM
Subscribers
None

Details

Summary

Ref T8510. We had two issues with mixed-case result sorting, like typing @joe to match user Joe.

  • The fallback sort was not normalized properly, so "J" could sort after "j". Instead, normalize values for sorting.
  • The prefix_hits and older priority_hits mechanisms were competing destructively. The prefix_hits mechanism completely replaces the priority_hits mechanism. Instead, use only the prefix_hits mechanism.
Test Plan
  • Copied results for "joe" from WMF.
  • Hard-coded the controller to return them.
  • Searched for @joe.
  • After patches, first hit is user "Joe".

Diff Detail

Repository
rP Phabricator
Branch
typeahead1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14407
Build 18767: Run Core Tests
Build 18766: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve typeahead behavior with mixed-case matches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 7:41 PM
This revision was automatically updated to reflect the committed changes.