Page MenuHomePhabricator

Improve typeahead behavior with mixed-case matches
ClosedPublic

Authored by epriestley on Nov 8 2016, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 8:57 PM
Unknown Object (File)
Mon, Apr 22, 3:10 AM
Unknown Object (File)
Fri, Apr 19, 5:38 PM
Unknown Object (File)
Thu, Apr 18, 3:21 PM
Unknown Object (File)
Fri, Apr 12, 7:17 AM
Unknown Object (File)
Wed, Apr 3, 10:24 AM
Unknown Object (File)
Wed, Apr 3, 10:24 AM
Unknown Object (File)
Wed, Apr 3, 10:24 AM
Subscribers
None

Details

Summary

Ref T8510. We had two issues with mixed-case result sorting, like typing @joe to match user Joe.

  • The fallback sort was not normalized properly, so "J" could sort after "j". Instead, normalize values for sorting.
  • The prefix_hits and older priority_hits mechanisms were competing destructively. The prefix_hits mechanism completely replaces the priority_hits mechanism. Instead, use only the prefix_hits mechanism.
Test Plan
  • Copied results for "joe" from WMF.
  • Hard-coded the controller to return them.
  • Searched for @joe.
  • After patches, first hit is user "Joe".

Diff Detail

Repository
rP Phabricator
Branch
typeahead1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14407
Build 18767: Run Core Tests
Build 18766: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve typeahead behavior with mixed-case matches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 7:41 PM
This revision was automatically updated to reflect the committed changes.