Page MenuHomePhabricator

Improve typeahead behavior with mixed-case matches
ClosedPublic

Authored by epriestley on Nov 8 2016, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 3:41 AM
Unknown Object (File)
Feb 16 2024, 12:29 PM
Unknown Object (File)
Feb 15 2024, 5:22 PM
Unknown Object (File)
Feb 3 2024, 12:46 PM
Unknown Object (File)
Jan 31 2024, 6:48 AM
Unknown Object (File)
Jan 28 2024, 12:57 AM
Unknown Object (File)
Jan 25 2024, 7:17 PM
Unknown Object (File)
Jan 19 2024, 8:12 AM
Subscribers
None

Details

Summary

Ref T8510. We had two issues with mixed-case result sorting, like typing @joe to match user Joe.

  • The fallback sort was not normalized properly, so "J" could sort after "j". Instead, normalize values for sorting.
  • The prefix_hits and older priority_hits mechanisms were competing destructively. The prefix_hits mechanism completely replaces the priority_hits mechanism. Instead, use only the prefix_hits mechanism.
Test Plan
  • Copied results for "joe" from WMF.
  • Hard-coded the controller to return them.
  • Searched for @joe.
  • After patches, first hit is user "Joe".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve typeahead behavior with mixed-case matches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 7:41 PM
This revision was automatically updated to reflect the committed changes.