Page MenuHomePhabricator
Differential D16804

Fix a Calendar import issue where we looked up attendees by object instead of name
ClosedPublic
Actions

Authored by epriestley on Nov 5 2016, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 12:33 AM
Unknown Object (File)
Sat, Apr 20, 12:32 AM
Unknown Object (File)
Fri, Apr 19, 5:35 PM
Unknown Object (File)
Thu, Apr 11, 10:04 AM
Unknown Object (File)
Wed, Apr 3, 7:36 PM
Unknown Object (File)
Mar 27 2024, 5:13 PM
Unknown Object (File)
Mar 5 2024, 5:20 AM
Unknown Object (File)
Mar 5 2024, 2:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11801: Calendar: ICS Import Errata
Commits
rPe1566bef63c2: Fix a Calendar import issue where we looked up attendees by object instead of…
Summary

Ref T11801. This issue led to the stack trace in T11801#199042.

It wasn't obvious that this was wrong because the recover-on-duplicate-key code made it work correctly.

Test Plan

Imported an event with external attendees with no warnings in the log.

Diff Detail

Repository
rP Phabricator
Branch
import1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14362
Build 18699: Run Core Tests
Build 18698: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40470.Nov 5 2016, 4:26 PM
epriestley retitled this revision from to Fix a Calendar import issue where we looked up attendees by object instead of name.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11801: Calendar: ICS Import Errata.
epriestley mentioned this in T11801: Calendar: ICS Import Errata.Nov 5 2016, 4:39 PM
chad accepted this revision.Nov 5 2016, 6:11 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 5 2016, 6:11 PM
Closed by commit rPe1566bef63c2: Fix a Calendar import issue where we looked up attendees by object instead of… (authored by epriestley, committed by epriestley). · Explain WhyNov 5 2016, 6:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
import/
2 lines

Diff 40470

View Options

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Loading...
Phabricator · Built by Phacility