Page MenuHomePhabricator

Fix a Calendar import issue where we looked up attendees by object instead of name
ClosedPublic

Authored by epriestley on Nov 5 2016, 4:26 PM.
Tags
None
Referenced Files
F15334743: D16804.id40471.diff
Sat, Mar 8, 11:48 AM
F15299147: D16804.id.diff
Wed, Mar 5, 2:20 PM
Unknown Object (File)
Wed, Feb 26, 5:59 AM
Unknown Object (File)
Mon, Feb 24, 5:49 AM
Unknown Object (File)
Tue, Feb 18, 11:58 AM
Unknown Object (File)
Jan 30 2025, 10:59 AM
Unknown Object (File)
Jan 30 2025, 1:12 AM
Unknown Object (File)
Jan 28 2025, 11:26 PM
Subscribers
None

Details

Summary

Ref T11801. This issue led to the stack trace in T11801#199042.

It wasn't obvious that this was wrong because the recover-on-duplicate-key code made it work correctly.

Test Plan

Imported an event with external attendees with no warnings in the log.

Diff Detail

Repository
rP Phabricator
Branch
import1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14362
Build 18699: Run Core Tests
Build 18698: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a Calendar import issue where we looked up attendees by object instead of name.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 5 2016, 6:11 PM
This revision was automatically updated to reflect the committed changes.