Page MenuHomePhabricator
Differential D16800

When we encounter a fanciful timezone identifier, try to guess what it might mean
ClosedPublic
Actions

Authored by epriestley on Nov 4 2016, 10:30 PM.
Tags
None
Referenced Files
F13159986: D16800.id40465.diff
Mon, May 6, 3:23 AM
Unknown Object (File)
Fri, May 3, 6:41 AM
Unknown Object (File)
Wed, May 1, 10:57 AM
Unknown Object (File)
Thu, Apr 25, 1:15 AM
Unknown Object (File)
Fri, Apr 19, 5:34 PM
Unknown Object (File)
Mon, Apr 8, 6:16 PM
Unknown Object (File)
Apr 3 2024, 11:10 AM
Unknown Object (File)
Apr 3 2024, 5:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11816: Calendar: Feedback and Suggestions
Commits
rPHU40e473e05788: (stable) Promote 2016 Week 45
rPHUe409df2720c2: When we encounter a fanciful timezone identifier, try to guess what it might…
Summary

Ref T11816. My read of RFC 5545 is that applications can do whatever they want here. Although most applications use legal timezonedb values like "America/Los_Angeles", at least one ("Zimbra") has at least one event with a weird value (TZID="(GMT-05.00) Auto-Detected").

Try to puzzle out what these mysterious identifiers might intend. For now, I added a rule to look for "UTC+3", "GMT-2:30", etc.

If we don't have any guesses, just use UTC. If we guess or fall back, raise a warning so the user can see what happened.

Test Plan

Added a unit test. See also next change.

Diff Detail

Repository
rPHU libphutil
Branch
tzid1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14351
Build 18684: Run Core Tests
Build 18683: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40462.Nov 4 2016, 10:30 PM
epriestley retitled this revision from to When we encounter a fanciful timezone identifier, try to guess what it might mean.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11816: Calendar: Feedback and Suggestions.
epriestley added a child revision: D16801: Raise ICS warnings in Phabricator on ICS import.Nov 4 2016, 10:39 PM
chad accepted this revision.Nov 4 2016, 10:54 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2016, 10:54 PM
Closed by commit rPHUe409df2720c2: When we encounter a fanciful timezone identifier, try to guess what it might… (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2016, 11:36 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 4 2016, 11:54 PM

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
ics/
79 lines
__tests__/
12 lines
data/
12 lines

Diff 40462

View Options

src/parser/calendar/ics/PhutilICSParser.php

Loading...
View Options

src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php

Loading...
View Options

src/parser/calendar/ics/__tests__/data/err-bad-tzid.ics

Loading...
View Options

src/parser/calendar/ics/__tests__/data/zimbra-timezone.ics

Loading...
Phabricator · Built by Phacility