Paths

Table of Contentst

Differential D16800

When we encounter a fanciful timezone identifier, try to guess what it might mean
ClosedPublic
Actions

Authored by epriestley on Nov 4 2016, 10:30 PM.

Tags

None

Referenced Files

	F14090052: D16800.diff
	Sun, Nov 24, 3:19 PM

	Unknown Object (File)
	Fri, Nov 22, 5:14 AM

	Unknown Object (File)
	Mon, Nov 18, 8:32 AM

	Unknown Object (File)
	Thu, Nov 14, 7:03 AM

	Unknown Object (File)
	Thu, Nov 14, 6:16 AM

	Unknown Object (File)
	Thu, Nov 14, 2:47 AM

	Unknown Object (File)
	Wed, Nov 13, 6:07 AM

	Unknown Object (File)
	Sun, Nov 10, 6:57 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11816: Calendar: Feedback and Suggestions

Commits

rPHU40e473e05788: (stable) Promote 2016 Week 45
rPHUe409df2720c2: When we encounter a fanciful timezone identifier, try to guess what it might…

Summary

Ref T11816. My read of RFC 5545 is that applications can do whatever they want here. Although most applications use legal timezonedb values like "America/Los_Angeles", at least one ("Zimbra") has at least one event with a weird value (TZID="(GMT-05.00) Auto-Detected").

Try to puzzle out what these mysterious identifiers might intend. For now, I added a rule to look for "UTC+3", "GMT-2:30", etc.

If we don't have any guesses, just use UTC. If we guess or fall back, raise a warning so the user can see what happened.

Test Plan

Added a unit test. See also next change.

Diff Detail

Repository

Branch

tzid1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14351
Build 18684: Run Core Tests
Build 18683: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40462.Nov 4 2016, 10:30 PM

epriestley retitled this revision from to When we encounter a fanciful timezone identifier, try to guess what it might mean.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11816: Calendar: Feedback and Suggestions.

epriestley added a child revision: D16801: Raise ICS warnings in Phabricator on ICS import.Nov 4 2016, 10:39 PM

chad accepted this revision.Nov 4 2016, 10:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2016, 10:54 PM

Closed by commit rPHUe409df2720c2: When we encounter a fanciful timezone identifier, try to guess what it might… (authored by epriestley, committed by epriestley). · Explain WhyNov 4 2016, 11:36 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 4 2016, 11:54 PM

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

ics/

PhutilICSParser.php

79 lines

__tests__/

PhutilICSParserTestCase.php

12 lines

data/

err-bad-tzid.ics

zimbra-timezone.ics

12 lines

Diff 40462

src/parser/calendar/ics/PhutilICSParser.php

Loading...

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

Loading...

src/parser/calendar/ics/tests/data/err-bad-tzid.ics

Loading...

src/parser/calendar/ics/tests/data/zimbra-timezone.ics

Loading...