Page MenuHomePhabricator

When we encounter a fanciful timezone identifier, try to guess what it might mean
ClosedPublic

Authored by epriestley on Nov 4 2016, 10:30 PM.
Tags
None
Referenced Files
F17808142: D16800.id40465.diff
Fri, Jul 25, 3:39 PM
Unknown Object (File)
Thu, Jul 3, 11:50 AM
Unknown Object (File)
Sat, Jun 28, 9:51 AM
Unknown Object (File)
Jun 16 2025, 11:10 AM
Unknown Object (File)
May 29 2025, 8:44 AM
Unknown Object (File)
May 10 2025, 1:45 PM
Unknown Object (File)
May 10 2025, 9:40 AM
Unknown Object (File)
May 9 2025, 9:43 AM
Subscribers
None

Details

Summary

Ref T11816. My read of RFC 5545 is that applications can do whatever they want here. Although most applications use legal timezonedb values like "America/Los_Angeles", at least one ("Zimbra") has at least one event with a weird value (TZID="(GMT-05.00) Auto-Detected").

Try to puzzle out what these mysterious identifiers might intend. For now, I added a rule to look for "UTC+3", "GMT-2:30", etc.

If we don't have any guesses, just use UTC. If we guess or fall back, raise a warning so the user can see what happened.

Test Plan

Added a unit test. See also next change.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When we encounter a fanciful timezone identifier, try to guess what it might mean.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2016, 10:54 PM
This revision was automatically updated to reflect the committed changes.