Page MenuHomePhabricator

When we encounter a fanciful timezone identifier, try to guess what it might mean
ClosedPublic

Authored by epriestley on Nov 4 2016, 10:30 PM.
Tags
None
Referenced Files
F18835864: D16800.id.diff
Sun, Oct 26, 7:31 PM
F18824457: D16800.id.diff
Thu, Oct 23, 3:48 PM
F18816019: D16800.diff
Tue, Oct 21, 4:38 AM
F18803094: D16800.diff
Fri, Oct 17, 9:36 PM
F18777828: D16800.id40465.diff
Sat, Oct 11, 5:44 AM
F18653048: D16800.id40462.diff
Sep 21 2025, 10:48 AM
F18612278: D16800.id.diff
Sep 14 2025, 8:59 AM
F18599934: D16800.diff
Sep 13 2025, 8:37 AM
Subscribers
None

Details

Summary

Ref T11816. My read of RFC 5545 is that applications can do whatever they want here. Although most applications use legal timezonedb values like "America/Los_Angeles", at least one ("Zimbra") has at least one event with a weird value (TZID="(GMT-05.00) Auto-Detected").

Try to puzzle out what these mysterious identifiers might intend. For now, I added a rule to look for "UTC+3", "GMT-2:30", etc.

If we don't have any guesses, just use UTC. If we guess or fall back, raise a warning so the user can see what happened.

Test Plan

Added a unit test. See also next change.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When we encounter a fanciful timezone identifier, try to guess what it might mean.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2016, 10:54 PM
This revision was automatically updated to reflect the committed changes.