Paths

Table of Contentst

Differential D16676

Make more of the Calendar export workflow work
ClosedPublic
Actions

Authored by epriestley on Oct 5 2016, 11:44 PM.

Tags

None

Referenced Files

	F14393698: D16676.id40154.diff
	Sun, Dec 22, 12:34 AM

	F14393697: D16676.id40139.diff
	Sun, Dec 22, 12:34 AM

	F14393643: D16676.id.diff
	Sun, Dec 22, 12:27 AM

	Unknown Object (File)
	Tue, Dec 17, 4:34 PM

	Unknown Object (File)
	Wed, Dec 11, 9:33 PM

	Unknown Object (File)
	Mon, Dec 9, 11:19 AM

	Unknown Object (File)
	Fri, Dec 6, 7:22 PM

	Unknown Object (File)
	Fri, Dec 6, 3:17 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPfa6a5a46ba57: Make more of the Calendar export workflow work

Summary

Adds a "Use Results..." dropdown to query result pages, with actions you can take with search results (today: create export; in future: bulk edit, export as excel, make dashboard panel, etc).
Allows you to create an export against a query key.
- I'm just using a text edit field for this for now.
Fleshes out export modes. I plan to support: public (as though you were logged out), privileged (as though you were logged in) and availability (event times, but not details).

This does not actually export stuff yet.

Test Plan

Created some exports. Viewed and listed exports.

Diff Detail

Repository

Branch

cal13

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14030
Build 18200: Run Core Tests
Build 18199: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40139.Oct 5 2016, 11:44 PM

epriestley retitled this revision from to Make more of the Calendar export workflow work.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

ffs this is a big diff

I can pull the action part out if you want to fiddle with that more or whatever, it just had to sort of do something and I kept going for a bit.

chad accepted this revision.Oct 6 2016, 12:36 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 6 2016, 12:36 AM

c4jt321.jpg (270×480 px, 49 KB)

Closed by commit rPfa6a5a46ba57: Make more of the Calendar export workflow work (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 11:14 AM

This revision was automatically updated to reflect the committed changes.

vrana added a subscriber: vrana.Feb 16 2017, 2:13 PM

vrana added inline comments.

src/applications/calendar/editor/PhabricatorCalendarExportEditEngine.php
73	I'm not sure what should happen here but `array_shift` accepts only the array to be shifted.

epriestley added inline comments.Feb 16 2017, 2:17 PM

src/applications/calendar/editor/PhabricatorCalendarExportEditEngine.php
73	I think this is supposed to be `array_unshift()`.

epriestley mentioned this in D17369: Fix a CalendarExport issue when an existing export has an unsupported mode.Feb 16 2017, 2:20 PM

epriestley mentioned this in rP01f277cef22c: Fix a CalendarExport issue when an existing export has an unsupported mode.Feb 16 2017, 2:22 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

calendar/

controller/

PhabricatorCalendarExportViewController.php

154 lines

editor/

PhabricatorCalendarExportEditEngine.php

39 lines

PhabricatorCalendarExportEditor.php

4 lines

query/

PhabricatorCalendarEventSearchEngine.php

26 lines

PhabricatorCalendarExportSearchEngine.php

10 lines

PhabricatorCalendarExportTransactionQuery.php

10 lines

storage/

PhabricatorCalendarExport.php

66 lines

xaction/

PhabricatorCalendarExportQueryKeyTransaction.php

10 lines

search/

controller/

PhabricatorApplicationSearchController.php

40 lines

engine/

PhabricatorApplicationSearchEngine.php

4 lines

Diff 40139

src/__phutil_library_map__.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarExportViewController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarExportEditEngine.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarExportEditor.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...

src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php

Loading...

src/applications/calendar/query/PhabricatorCalendarExportTransactionQuery.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarExport.php

Loading...

src/applications/calendar/xaction/PhabricatorCalendarExportQueryKeyTransaction.php

Loading...

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...