Page MenuHomePhabricator

Remove Windows workarounds from ArcanistGitAPI
AbandonedPublic

Authored by BYK on Apr 13 2016, 6:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 4:46 AM
Unknown Object (File)
Sat, Nov 23, 1:21 AM
Unknown Object (File)
Tue, Nov 19, 6:39 AM
Unknown Object (File)
Tue, Nov 12, 7:18 PM
Unknown Object (File)
Fri, Nov 8, 8:43 AM
Unknown Object (File)
Tue, Oct 29, 6:41 AM
Unknown Object (File)
Mon, Oct 28, 12:50 PM
Unknown Object (File)
Oct 22 2024, 5:19 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

D15675 fixes rPHU so we don't need the workarounds for Windows in the Git API anymore. In fact they are broken with D15675 since they are either incorrectly escaped or double-escaped.

Depends on D15675.

Test Plan

manually verified.

Diff Detail

Repository
rARC Arcanist
Branch
windows-escapes
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 13997
Build 18143: arc lint + arc unit

Unit TestsFailed

TimeTest
2,492 msArcanistRepositoryAPIStateTestCase::Unknown Unit Message ("")
EXCEPTION (CommandException): Command failed with error #2! COMMAND tar -C C:\Users\BYK\AppData\Local\Temp\21m4t71d5flwgs84/ -xzvvf C:\Users\BYK\AppData\Roaming\PortableApps\Arcanist\arcanist\src\repository\api\__tests__\state\git_basic.git.tgz
209 msArcanistLibraryTestCase::Unknown Unit Message ("")
1 assertion passed.
59 msArcanistLibraryTestCase::Unknown Unit Message ("")
1 assertion passed.
54 msArcanistLibraryTestCase::Unknown Unit Message ("")
1 assertion passed.
2 msArcanistRepositoryAPIMiscTestCase::Unknown Unit Message ("")
1 assertion passed.
View Full Test Results (1 Failed · 4 Passed · 2 Skipped)

Event Timeline

BYK retitled this revision from to Remove Windows workarounds from ArcanistGitAPI.
BYK updated this object.
BYK edited the test plan for this revision. (Show Details)
BYK added a reviewer: epriestley.
BYK added a parent revision: D15675: Fix Windows escaping.
BYK added a subscriber: hach-que.
BYK edited edge metadata.

rebase