Differential D15693

Remove Windows workarounds from ArcanistGitAPI
AbandonedPublic
Actions

Authored by BYK on Apr 13 2016, 6:11 AM.

Tags

None

Referenced Files

	F14109962: D15693.diff
	Wed, Nov 27, 3:59 PM

	Unknown Object (File)
	Mon, Nov 25, 8:59 AM

	Unknown Object (File)
	Sun, Nov 24, 6:13 AM

	Unknown Object (File)
	Sat, Nov 23, 4:46 AM

	Unknown Object (File)
	Sat, Nov 23, 1:21 AM

	Unknown Object (File)
	Tue, Nov 19, 6:39 AM

	Unknown Object (File)
	Tue, Nov 12, 7:18 PM

	Unknown Object (File)
	Fri, Nov 8, 8:43 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

D15675 fixes rPHU so we don't need the workarounds for Windows in the Git API anymore. In fact they are broken with D15675 since they are either incorrectly escaped or double-escaped.

Depends on D15675.

Test Plan

manually verified.

Diff Detail

Repository

Branch

windows-escapes

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 12729
Build 16190: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2,597 ms	ArcanistRepositoryAPIStateTestCase::Unknown Unit Message ("") EXCEPTION (CommandException): Command failed with error #2! COMMAND tar -C C:\Users\BYK\AppData\Local\Temp\7glw0eay76040wgw/ -xzvvf C:\Users\BYK\AppData\Roaming\PortableApps\Arcanist\arcanist\src\repository\api\__tests__\state\git_basic.git.tgz
	498 ms	ArcanistLibraryTestCase::Unknown Unit Message ("") 1 assertion passed.
	234 ms	ArcanistLibraryTestCase::Unknown Unit Message ("") 1 assertion passed.
	2 ms	ArcanistLibraryTestCase::Unknown Unit Message ("") 1 assertion passed.
	4 ms	ArcanistRepositoryAPIMiscTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (1 Failed · 4 Passed · 2 Skipped)

Event Timeline

BYK updated this revision to Diff 37814.Apr 13 2016, 6:11 AM

BYK retitled this revision from to Remove Windows workarounds from ArcanistGitAPI.

BYK updated this object.

BYK edited the test plan for this revision. (Show Details)

BYK added a reviewer: epriestley.

BYK added a parent revision: D15675: Fix Windows escaping.

BYK added a subscriber: hach-que.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2016, 6:11 AM

Herald added a subscriber: Korvin. · View Herald Transcript

BYK mentioned this in D15675: Fix Windows escaping.Apr 15 2016, 9:09 AM

rebase

BYK mentioned this in T8298: Fix Windows Escaping.Jul 25 2016, 5:10 PM

rebase

rebase

• liugev6 added a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 8:51 AM

epriestley removed a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 12:09 PM

rebase

• TweikerManager added a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:50 PM

epriestley removed a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:52 PM

nickhutchinson added a subscriber: nickhutchinson.Mar 7 2017, 9:37 AM

jlbrown added a subscriber: jlbrown.Mar 29 2017, 2:08 PM

BYK abandoned this revision.Jan 8 2018, 3:03 PM

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

28 lines

Diff 38849

src/repository/api/ArcanistGitAPI.php

Loading...