Page MenuHomePhabricator

Don't mark a thread as seen if durable column is minimized
ClosedPublic

Authored by chad on Oct 3 2016, 3:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:41 PM
Unknown Object (File)
Wed, May 1, 11:18 PM
Unknown Object (File)
Tue, Apr 30, 11:24 PM
Unknown Object (File)
Sat, Apr 27, 11:17 AM
Unknown Object (File)
Mon, Apr 22, 10:42 PM
Unknown Object (File)
Tue, Apr 16, 5:09 PM
Unknown Object (File)
Thu, Apr 11, 7:28 AM
Unknown Object (File)
Wed, Apr 10, 8:18 PM
Subscribers

Details

Summary

More work to do here on the JS side, but this at least makes sure users with a small chat window have some notification marked that new replies have not been seen.

Test Plan

Open two windows. Window 1 has durable minimized, Window 2 is full conpherence. Send a message from Window 2, see header count in Window 1 increase. Repeat with durable open, see no change in window.

Diff Detail

Repository
rP Phabricator
Branch
conph-up-to-date (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13974
Build 18108: Run Core Tests
Build 18107: arc lint + arc unit

Event Timeline

chad retitled this revision from to Don't mark a thread as seen if durable column is minimized.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 3:30 AM
This revision was automatically updated to reflect the committed changes.