Differential D16650

Don't mark a thread as seen if durable column is minimized
ClosedPublic
Actions

Authored by chad on Oct 3 2016, 3:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 1:10 AM

	Unknown Object (File)
	Sun, Dec 15, 7:20 AM

	Unknown Object (File)
	Thu, Dec 12, 9:05 PM

	Unknown Object (File)
	Thu, Dec 12, 12:57 AM

	Unknown Object (File)
	Thu, Dec 5, 9:00 AM

	Unknown Object (File)
	Thu, Nov 28, 8:48 AM

	Unknown Object (File)
	Wed, Nov 27, 11:14 PM

	Unknown Object (File)
	Nov 9 2024, 6:29 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T11726: Durable Column "minimized" should notify you of new messages in rooms

Commits

rPda1ed2c63ac9: Don't mark a thread as seen if durable column is minimized

Summary

More work to do here on the JS side, but this at least makes sure users with a small chat window have some notification marked that new replies have not been seen.

Test Plan

Open two windows. Window 1 has durable minimized, Window 2 is full conpherence. Send a message from Window 2, see header count in Window 1 increase. Repeat with durable open, see no change in window.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40083.Oct 3 2016, 3:13 AM

chad retitled this revision from to Don't mark a thread as seen if durable column is minimized.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 3 2016, 3:13 AM

epriestley accepted this revision.Oct 3 2016, 3:30 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 3 2016, 3:30 AM

Closed by commit rPda1ed2c63ac9: Don't mark a thread as seen if durable column is minimized (authored by chad, committed by chad). · Explain WhyOct 3 2016, 3:31 AM

This revision was automatically updated to reflect the committed changes.

chad added a task: T11726: Durable Column "minimized" should notify you of new messages in rooms.Oct 3 2016, 6:04 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

9 lines

Diff 40084

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...