Page MenuHomePhabricator

Don't mark a thread as seen if durable column is minimized
ClosedPublic

Authored by chad on Oct 3 2016, 3:13 AM.
Tags
None
Referenced Files
F18160698: D16650.id40084.diff
Aug 15 2025, 2:16 AM
F18108272: D16650.id40083.diff
Aug 11 2025, 5:55 AM
F18098488: D16650.id.diff
Aug 8 2025, 8:29 PM
F18098251: D16650.id40084.diff
Aug 8 2025, 7:18 PM
F18098187: D16650.id40083.diff
Aug 8 2025, 7:08 PM
F18096895: D16650.diff
Aug 8 2025, 9:53 AM
F17852183: D16650.id.diff
Jul 27 2025, 12:15 PM
F17826940: D16650.diff
Jul 26 2025, 7:46 AM
Subscribers

Details

Summary

More work to do here on the JS side, but this at least makes sure users with a small chat window have some notification marked that new replies have not been seen.

Test Plan

Open two windows. Window 1 has durable minimized, Window 2 is full conpherence. Send a message from Window 2, see header count in Window 1 increase. Repeat with durable open, see no change in window.

Diff Detail

Repository
rP Phabricator
Branch
conph-up-to-date (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13974
Build 18108: Run Core Tests
Build 18107: arc lint + arc unit

Event Timeline

chad retitled this revision from to Don't mark a thread as seen if durable column is minimized.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 3:30 AM
This revision was automatically updated to reflect the committed changes.