Page MenuHomePhabricator

Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES
ClosedPublic

Authored by epriestley on Sep 28 2016, 12:17 AM.
Tags
None
Referenced Files
F13186455: D16612.diff
Sat, May 11, 3:38 AM
Unknown Object (File)
Tue, May 7, 6:55 AM
Unknown Object (File)
Fri, May 3, 4:33 AM
Unknown Object (File)
Mon, Apr 29, 4:35 PM
Unknown Object (File)
Fri, Apr 26, 2:29 AM
Unknown Object (File)
Fri, Apr 26, 2:25 AM
Unknown Object (File)
Fri, Apr 26, 2:25 AM
Unknown Object (File)
Thu, Apr 25, 12:36 AM
Subscribers
None

Details

Summary

Ref T10747. If you have an all-day event, we normally return all-day events.

If the frequency is HOURLY or higher though, or the set has been expanded by a rule like BYHOUR, we need to iterate hours/minutes/seconds and return date-time results.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Branch
cal10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13874
Build 17956: Run Core Tests
Build 17955: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 12:40 AM
This revision was automatically updated to reflect the committed changes.