Page MenuHomePhabricator

Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES
ClosedPublic

Authored by epriestley on Sep 28 2016, 12:17 AM.
Tags
None
Referenced Files
F22726883: D16612.id39985.diff
Sun, Oct 4, 3:06 AM
F22602220: D16612.diff
Mon, Sep 28, 7:24 PM
Unknown Object (File)
Aug 12 2026, 1:14 PM
Unknown Object (File)
Jul 11 2026, 1:56 AM
Unknown Object (File)
Jul 2 2026, 3:30 PM
Unknown Object (File)
Jun 24 2026, 10:03 AM
Unknown Object (File)
Apr 16 2026, 9:19 PM
Unknown Object (File)
Apr 12 2026, 7:46 PM
Subscribers
None

Details

Summary

Ref T10747. If you have an all-day event, we normally return all-day events.

If the frequency is HOURLY or higher though, or the set has been expanded by a rule like BYHOUR, we need to iterate hours/minutes/seconds and return date-time results.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Branch
cal10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13874
Build 17956: Run Core Tests
Build 17955: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 12:40 AM
This revision was automatically updated to reflect the committed changes.