Page MenuHomePhabricator

Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES
ClosedPublic

Authored by epriestley on Sep 28 2016, 12:17 AM.
Tags
None
Referenced Files
F19304605: D16612.diff
Wed, Dec 24, 1:28 PM
F19259206: D16612.diff
Mon, Dec 22, 3:19 PM
F19072226: D16612.id40002.diff
Nov 30 2025, 9:46 PM
F19059182: D16612.id40002.diff
Nov 29 2025, 4:44 AM
F19031342: D16612.id39985.diff
Nov 25 2025, 12:10 AM
F19031338: D16612.id39985.diff
Nov 25 2025, 12:08 AM
F18907172: D16612.diff
Nov 8 2025, 10:14 PM
F18906975: D16612.diff
Nov 8 2025, 9:28 PM
Subscribers
None

Details

Summary

Ref T10747. If you have an all-day event, we normally return all-day events.

If the frequency is HOURLY or higher though, or the set has been expanded by a rule like BYHOUR, we need to iterate hours/minutes/seconds and return date-time results.

Test Plan

Unit tests now pass.

Diff Detail

Repository
rPHU libphutil
Branch
cal10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13874
Build 17956: Run Core Tests
Build 17955: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix an RRULE issue with all-day events expanded by BYHOUR or high-frequency RRULES.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 12:40 AM
This revision was automatically updated to reflect the committed changes.