Differential D16610

Fix some RRULE bugs with BYWEEKNO
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 11:39 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU9db0dd4fe2fd: Fix some RRULE bugs with BYWEEKNO

Summary

Ref T10747. A few typos, plus we need to expand months, plus the initial week calculation was slightly wrong.

Test Plan

Unit tests now pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13872
Build 17952: Run Core Tests
Build 17951: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39983.Sep 27 2016, 11:39 PM

epriestley retitled this revision from to Fix some RRULE bugs with BYWEEKNO.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 28 2016, 12:08 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 12:08 AM

Closed by commit rPHU9db0dd4fe2fd: Fix some RRULE bugs with BYWEEKNO (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

11 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

50 lines

Diff 39983

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Fix some RRULE bugs with BYWEEKNOClosedPublicActions