Fixes T10681. Adds a search API endpoint and an edit API endpoint for Phurl URLs. I still need to add the ability to search by name, alias, URL, and maybe description.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T10681: Add Phurl Conduit API methods
- Commits
- rPfc821188483e: Expose conduit API methods for Phurl URLs
Test the methods through /conduit/method/phurls.search/ and /conduit/method/phurls.edit/
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- PhurlConduitAPI
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 13855 Build 17923: Run Core Tests Build 17922: arc lint + arc unit
Event Timeline
| src/applications/phurl/conduit/PhabricatorPhurlURLEditConduitAPIMethod.php | ||
|---|---|---|
| 17 | By convention, prefer capitalizing application names ("Phurl"). | |
| src/applications/phurl/storage/PhabricatorPhurlURL.php | ||
| 236 | We don't actually return the short URL anywhere, but it seems possibly useful? Maybe: 'urls' => array( 'long' => $this->getLongURL(), 'short' => $this->getRedirectURI(), ), Although you'll need to fiddle with getRedirectURI() to make sure it always has a protocol/domain, since it currently won't if phurl.short-uri is unconfigured. | |