Differential D16570

Update DarkConsole for handleRequest
ClosedPublic
Actions

Authored by jcox on Sep 19 2016, 12:38 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

rP2e4b5b45a20b: Update DarkConsole for handleRequest

Summary

Ref T8628

Test Plan

Updated DarkConsoleDataController and observed that the darkconsole still works as expected

Diff Detail

Repository

rP Phabricator

Branch

UpdateAphrontControllers (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13766
Build 17781: Run Core Tests
Build 17780: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39882.Sep 19 2016, 12:38 PM

jcox retitled this revision from to Update DarkConsole for handleRequest.

jcox updated this object.

jcox edited the test plan for this revision. (Show Details)

jcox added a task: T8628: Modernize AphrontControllers to implement handleRequest.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 19 2016, 12:38 PM

Herald added subscribers: yelirekim, epriestley. · View Herald Transcript

epriestley accepted this revision.Sep 19 2016, 5:06 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Sep 19 2016, 5:06 PM

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptSep 19 2016, 5:18 PM

Closed by commit rP2e4b5b45a20b: Update DarkConsole for handleRequest (authored by jcox, committed by jcox). · Explain WhySep 19 2016, 5:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

console/

controller/

DarkConsoleDataController.php

16 lines

Diff 39886

View Options

src/applications/console/controller/DarkConsoleDataController.php

Update DarkConsole for handleRequestClosedPublicActions