Differential D16571

Update RedirectController for handleRequest
ClosedPublic
Actions

Authored by jcox on Sep 19 2016, 12:42 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

rP799ecdc27886: Update RedirectController for handleRequest

Summary

Ref T8628.

Test Plan

Performed an action that uses the redirect controller (trying to visit a repo page while not logged in). Logged in and was redirected as expected

Diff Detail

Repository

rP Phabricator

Branch

RedirectAphront (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13763
Build 17776: Run Core Tests
Build 17775: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39883.Sep 19 2016, 12:42 PM

jcox retitled this revision from to Update RedirectController for handleRequest.

jcox updated this object.

jcox edited the test plan for this revision. (Show Details)

jcox added a task: T8628: Modernize AphrontControllers to implement handleRequest.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 19 2016, 12:42 PM

Herald added subscribers: yelirekim, epriestley. · View Herald Transcript

epriestley accepted this revision.Sep 19 2016, 5:06 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Sep 19 2016, 5:06 PM

Closed by commit rP799ecdc27886: Update RedirectController for handleRequest (authored by jcox, committed by jcox). · Explain WhySep 19 2016, 5:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorRedirectController.php

16 lines

Diff 39883

View Options

src/applications/base/controller/PhabricatorRedirectController.php

Update RedirectController for handleRequestClosedPublicActions