Page MenuHomePhabricator
Differential D16569

Added a 'name' field to the results for harbormaster.build.search endpoint
ClosedPublic
Actions

Authored by jcox on Sep 19 2016, 12:04 PM.
Tags
None
Referenced Files
F19528108: D16569.id39881.diff
Mon, Jan 19, 6:44 AM
F19528107: D16569.id39881.diff
Mon, Jan 19, 6:44 AM
F19096714: D16569.id.diff
Dec 4 2025, 10:37 AM
F19094216: D16569.diff
Dec 3 2025, 11:41 PM
F18856663: D16569.id.diff
Nov 1 2025, 10:56 AM
F18854358: D16569.diff
Oct 31 2025, 11:37 PM
F18837662: D16569.diff
Oct 27 2025, 7:14 AM
F18761189: D16569.id.diff
Oct 6 2025, 12:48 PM
View All Files
Subscribers
epriestley
yelirekim

Details

Reviewers
epriestley
yelirekim
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11642: Add "name" field to `harbormaster.build.search` results
Commits
rPdda06c6bdc74: Added a 'name' field to the results for harbormaster.build.search endpoint
Summary

Fixes T11642. Added a 'name' field to the results from harbormaster.build.search.

Test Plan

Went to /conduit/method/harbormaster.build.search/ and ran a search that would yield results (because otherwise there will be nothing there). Noted that there was, in fact, a name in the results.

Diff Detail

Repository
rP Phabricator
Branch
NameForHBBuilds (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13761
Build 17772: Run Core Tests
Build 17771: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39881.Sep 19 2016, 12:04 PM
jcox retitled this revision from to Added a 'name' field to the results for harbormaster.build.search endpoint.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T11642: Add "name" field to `harbormaster.build.search` results.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 19 2016, 12:04 PM
Herald added subscribers: yelirekim, epriestley. · View Herald Transcript
yelirekim accepted this revision.Sep 19 2016, 12:34 PM
yelirekim added a reviewer: yelirekim.
epriestley accepted this revision.Sep 19 2016, 5:03 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Sep 19 2016, 5:03 PM
Closed by commit rPdda06c6bdc74: Added a 'name' field to the results for harbormaster.build.search endpoint (authored by jcox, committed by jcox). · Explain WhySep 19 2016, 5:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
storage/
build/
5 lines

Diff 39881

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility