Page MenuHomePhabricator
Differential D16569

Added a 'name' field to the results for harbormaster.build.search endpoint
ClosedPublic
Actions

Authored by jcox on Sep 19 2016, 12:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:28 AM
Unknown Object (File)
Thu, Dec 12, 4:28 AM
Unknown Object (File)
Mon, Dec 9, 7:25 PM
Unknown Object (File)
Thu, Dec 5, 7:57 AM
Unknown Object (File)
Nov 3 2024, 6:27 AM
Unknown Object (File)
Oct 24 2024, 9:27 AM
Unknown Object (File)
Oct 17 2024, 3:33 AM
Unknown Object (File)
Oct 16 2024, 1:52 PM
View All Files
Subscribers
epriestley
yelirekim

Details

Reviewers
epriestley
yelirekim
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11642: Add "name" field to `harbormaster.build.search` results
Commits
rPdda06c6bdc74: Added a 'name' field to the results for harbormaster.build.search endpoint
Summary

Fixes T11642. Added a 'name' field to the results from harbormaster.build.search.

Test Plan

Went to /conduit/method/harbormaster.build.search/ and ran a search that would yield results (because otherwise there will be nothing there). Noted that there was, in fact, a name in the results.

Diff Detail

Repository
rP Phabricator
Branch
NameForHBBuilds (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13761
Build 17772: Run Core Tests
Build 17771: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39881.Sep 19 2016, 12:04 PM
jcox retitled this revision from to Added a 'name' field to the results for harbormaster.build.search endpoint.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T11642: Add "name" field to `harbormaster.build.search` results.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 19 2016, 12:04 PM
Herald added subscribers: yelirekim, epriestley. · View Herald Transcript
yelirekim accepted this revision.Sep 19 2016, 12:34 PM
yelirekim added a reviewer: yelirekim.
epriestley accepted this revision.Sep 19 2016, 5:03 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Sep 19 2016, 5:03 PM
Closed by commit rPdda06c6bdc74: Added a 'name' field to the results for harbormaster.build.search endpoint (authored by jcox, committed by jcox). · Explain WhySep 19 2016, 5:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
storage/
build/
5 lines

Diff 39881

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility