Paths

Table of Contentst

Differential D16521

Make error handling for ICS parsing more robust
ClosedPublic
Actions

Authored by epriestley on Sep 8 2016, 10:49 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHUf8af794b2135: Make error handling for ICS parsing more robust

Summary

Ref T10747. This mostly adds a bunch of test cases for the ICS format syntax errors, and fixes a couple of issues:

Multiple VCALENDAR sections in one .ics file is legal according to the spec.
Had some bugs with parsing properties with multiple parameters.
Tighten up the regexp for property names.
Show a lot more detail about what went wrong when parsing fails.

Test Plan

Ran unit tests.

Diff Detail

Repository

rPHU libphutil

Branch

ics2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13643
Build 17586: Run Core Tests
Build 17585: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39760.Sep 8 2016, 10:49 PM

epriestley retitled this revision from to Make error handling for ICS parsing more robust.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 9 2016, 1:22 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 9 2016, 1:22 AM

Closed by commit rPHUf8af794b2135: Make error handling for ICS parsing more robust (authored by epriestley, committed by epriestley). · Explain WhySep 12 2016, 2:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

parser/

calendar/

data/

PhutilCalendarRawNode.php

2 lines

PhutilCalendarRootNode.php

12 lines

ics/

PhutilICSParser.php

172 lines

PhutilICSParserException.php

16 lines

__tests__/

PhutilICSParserTestCase.php

68 lines

data/

err-bad-base64.ics

5 lines

err-bad-boolean.ics

5 lines

err-extra-end.ics

1 line

err-initial-unfold.ics

2 lines

err-malformed-double-quote.ics

5 lines

err-malformed-parameter.ics

5 lines

err-malformed-property.ics

5 lines

err-missing-end.ics

2 lines

err-missing-value.ics

5 lines

err-mixmatched-sections.ics

4 lines

err-root-property.ics

1 line

err-unescaped-backslash.ics

5 lines

err-unexpected-child.ics

6 lines

err-unexpected-text.ics

5 lines

good-boolean.ics

5 lines

multiple-vcalendars.ics

4 lines

Diff 39760

View Options

src/__phutil_library_map__.php

View Options

src/parser/calendar/data/PhutilCalendarRawNode.php

View Options

src/parser/calendar/data/PhutilCalendarRootNode.php

View Options

src/parser/calendar/ics/PhutilICSParser.php

View Options

src/parser/calendar/ics/PhutilICSParserException.php

View Options

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

View Options

src/parser/calendar/ics/tests/data/err-bad-base64.ics

View Options

src/parser/calendar/ics/tests/data/err-bad-boolean.ics

View Options

src/parser/calendar/ics/tests/data/err-extra-end.ics

View Options

src/parser/calendar/ics/tests/data/err-initial-unfold.ics

View Options

src/parser/calendar/ics/tests/data/err-malformed-double-quote.ics

View Options

src/parser/calendar/ics/tests/data/err-malformed-parameter.ics

View Options

src/parser/calendar/ics/tests/data/err-malformed-property.ics

View Options

src/parser/calendar/ics/tests/data/err-missing-end.ics

View Options

src/parser/calendar/ics/tests/data/err-missing-value.ics

View Options

src/parser/calendar/ics/tests/data/err-mixmatched-sections.ics

View Options

src/parser/calendar/ics/tests/data/err-root-property.ics

View Options

src/parser/calendar/ics/tests/data/err-unescaped-backslash.ics

View Options

src/parser/calendar/ics/tests/data/err-unexpected-child.ics

View Options

src/parser/calendar/ics/tests/data/err-unexpected-text.ics

View Options

src/parser/calendar/ics/tests/data/good-boolean.ics

View Options

src/parser/calendar/ics/tests/data/multiple-vcalendars.ics

Make error handling for ICS parsing more robustClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39760

src/__phutil_library_map__.php

src/parser/calendar/data/PhutilCalendarRawNode.php

src/parser/calendar/data/PhutilCalendarRootNode.php

src/parser/calendar/ics/PhutilICSParser.php

src/parser/calendar/ics/PhutilICSParserException.php

src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php

src/parser/calendar/ics/__tests__/data/err-bad-base64.ics

src/parser/calendar/ics/__tests__/data/err-bad-boolean.ics

src/parser/calendar/ics/__tests__/data/err-extra-end.ics

src/parser/calendar/ics/__tests__/data/err-initial-unfold.ics

src/parser/calendar/ics/__tests__/data/err-malformed-double-quote.ics

src/parser/calendar/ics/__tests__/data/err-malformed-parameter.ics

src/parser/calendar/ics/__tests__/data/err-malformed-property.ics

src/parser/calendar/ics/__tests__/data/err-missing-end.ics

src/parser/calendar/ics/__tests__/data/err-missing-value.ics

src/parser/calendar/ics/__tests__/data/err-mixmatched-sections.ics

src/parser/calendar/ics/__tests__/data/err-root-property.ics

src/parser/calendar/ics/__tests__/data/err-unescaped-backslash.ics

src/parser/calendar/ics/__tests__/data/err-unexpected-child.ics

src/parser/calendar/ics/__tests__/data/err-unexpected-text.ics

src/parser/calendar/ics/__tests__/data/good-boolean.ics

src/parser/calendar/ics/__tests__/data/multiple-vcalendars.ics

Make error handling for ICS parsing more robust
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

src/parser/calendar/ics/tests/data/err-bad-base64.ics

src/parser/calendar/ics/tests/data/err-bad-boolean.ics

src/parser/calendar/ics/tests/data/err-extra-end.ics

src/parser/calendar/ics/tests/data/err-initial-unfold.ics

src/parser/calendar/ics/tests/data/err-malformed-double-quote.ics

src/parser/calendar/ics/tests/data/err-malformed-parameter.ics

src/parser/calendar/ics/tests/data/err-malformed-property.ics

src/parser/calendar/ics/tests/data/err-missing-end.ics

src/parser/calendar/ics/tests/data/err-missing-value.ics

src/parser/calendar/ics/tests/data/err-mixmatched-sections.ics

src/parser/calendar/ics/tests/data/err-root-property.ics

src/parser/calendar/ics/tests/data/err-unescaped-backslash.ics

src/parser/calendar/ics/tests/data/err-unexpected-child.ics

src/parser/calendar/ics/tests/data/err-unexpected-text.ics

src/parser/calendar/ics/tests/data/good-boolean.ics

src/parser/calendar/ics/tests/data/multiple-vcalendars.ics