Page MenuHomePhabricator
Differential D16439

Removed unused buildApplicationPage method from PhabricatorController
ClosedPublic
Actions

Authored by jcox on Aug 24 2016, 3:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:40 PM
Unknown Object (File)
Tue, Dec 3, 1:08 PM
Unknown Object (File)
Mon, Nov 25, 8:46 PM
Unknown Object (File)
Mon, Nov 25, 1:50 AM
Unknown Object (File)
Nov 16 2024, 11:44 AM
Unknown Object (File)
Oct 23 2024, 5:30 PM
Unknown Object (File)
Oct 20 2024, 11:48 PM
Unknown Object (File)
Oct 20 2024, 2:34 PM
View All Files
Subscribers
epriestley
yelirekim

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
rP2201c65eb73f: Removed unused buildApplicationPage method from PhabricatorController
Summary

Getting rid of some code! This method has no callsites so it should be safe to remove completely. Ref T9690

Test Plan

Removed method and clicked around to make sure nothing broke.

Diff Detail

Repository
rP Phabricator
Branch
RemoveBuildAppPageMethod (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13410
Build 17224: Run Core Tests
Build 17223: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39534.Aug 24 2016, 3:01 PM
jcox retitled this revision from to Removed unused buildApplicationPage method from PhabricatorController.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T9690: Remove calls to methods deprecated by newPage().
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2016, 3:01 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Aug 24 2016, 3:22 PM
epriestley added a reviewer: epriestley.

Nice.

This revision is now accepted and ready to land.Aug 24 2016, 3:22 PM
yelirekim added a subscriber: yelirekim.Aug 24 2016, 3:24 PM
yelirekim added inline comments.
src/applications/base/controller/PhabricatorController.php
587

RIP

yelirekim added a comment.Aug 24 2016, 3:25 PM

This is an ATC meme-ish at this point because I wrote so many controllers without page titles when I first starting extending Phab.

Closed by commit rP2201c65eb73f: Removed unused buildApplicationPage method from PhabricatorController (authored by jcox, committed by jcox). · Explain WhyAug 24 2016, 3:25 PM
This revision was automatically updated to reflect the committed changes.
jcox added inline comments.Aug 24 2016, 3:27 PM
src/applications/base/controller/PhabricatorController.php
585

I'm glad this lets me know we're dealing with serious-business here.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
40 lines

Diff 39534

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
Phabricator · Built by Phacility