Page MenuHomePhabricator
Differential D16350

Allow `*.search` Conduit API methods to have data bulk-loaded by extensions
ClosedPublic
Actions

Authored by epriestley on Jul 31 2016, 3:29 PM.
Tags
None
Referenced Files
F15436718: D16350.id39319.diff
Tue, Mar 25, 4:10 PM
F15435109: D16350.id.diff
Tue, Mar 25, 6:50 AM
F15432564: D16350.diff
Mon, Mar 24, 6:35 PM
F15431490: D16350.diff
Mon, Mar 24, 12:36 PM
F15422849: D16350.id39319.diff
Sat, Mar 22, 11:04 AM
F15416725: D16350.id39327.diff
Thu, Mar 20, 1:10 PM
F15409588: D16350.diff
Wed, Mar 19, 4:44 AM
F15377537: D16350.id39319.diff
Thu, Mar 13, 9:29 AM
View All Files
Subscribers
None

Details

Reviewers
yelirekim
chad
Maniphest Tasks
T11404: Improve the performance of custom field queries
Commits
rP6e57582aff82: Allow `*.search` Conduit API methods to have data bulk-loaded by extensions
Summary

Ref T11404. Currently, SearchEngineAttachments can bulk-load data but SearchEngineExtensions can not.

This leads to poor performance of custom fields. See T11404 for discussion.

This changes the API to support a bulk load + format pattern like the one Attachments use. The next change will use it to bulk-load custom field data.

Test Plan
  • Ran differential.query, differential.revision.search as a sanity check.
  • No behavioral changes are expected
  • See next revision.

Diff Detail

Repository
rP Phabricator
Branch
cfield1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13198
Build 16903: Run Core Tests
Build 16902: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39319.Jul 31 2016, 3:29 PM
epriestley retitled this revision from to Allow `*.search` Conduit API methods to have data bulk-loaded by extensions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
epriestley added a task: T11404: Improve the performance of custom field queries.
chad accepted this revision.Jul 31 2016, 3:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 31 2016, 3:37 PM
epriestley added a child revision: D16351: Improve Conduit performance for custom fields.Jul 31 2016, 3:46 PM
Closed by commit rP6e57582aff82: Allow `*.search` Conduit API methods to have data bulk-loaded by extensions (authored by epriestley, committed by epriestley). · Explain WhyJul 31 2016, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
query/
2 lines
policy/
engineextension/
2 lines
search/
engine/
16 lines
engineextension/
2 lines
6 lines
spaces/
engineextension/
2 lines
infrastructure/
customfield/
engineextension/
2 lines

Diff 39319

View Options

src/applications/conduit/query/ConduitResultSearchEngineExtension.php

Loading...
View Options

src/applications/policy/engineextension/PhabricatorPolicySearchEngineExtension.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorLiskSearchEngineExtension.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorSearchEngineExtension.php

Loading...
View Options

src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php

Loading...
Phabricator · Built by Phacility