Page MenuHomePhabricator
Differential D16350

Allow `*.search` Conduit API methods to have data bulk-loaded by extensions
ClosedPublic
Actions

Authored by epriestley on Jul 31 2016, 3:29 PM.
Tags
None
Referenced Files
F18663447: D16350.id.diff
Tue, Sep 23, 10:39 PM
F18629389: D16350.diff
Tue, Sep 16, 8:39 AM
F18600792: D16350.id39319.diff
Sat, Sep 13, 10:36 AM
F18507940: D16350.id.diff
Fri, Sep 5, 2:31 AM
F18182489: D16350.id39327.diff
Aug 16 2025, 9:44 AM
F18104949: D16350.id39319.diff
Aug 10 2025, 3:15 PM
F18103553: D16350.id.diff
Aug 10 2025, 6:22 AM
F18101961: D16350.diff
Aug 9 2025, 5:05 PM
View All Files
Subscribers
None

Details

Reviewers
yelirekim
chad
Maniphest Tasks
T11404: Improve the performance of custom field queries
Commits
rP6e57582aff82: Allow `*.search` Conduit API methods to have data bulk-loaded by extensions
Summary

Ref T11404. Currently, SearchEngineAttachments can bulk-load data but SearchEngineExtensions can not.

This leads to poor performance of custom fields. See T11404 for discussion.

This changes the API to support a bulk load + format pattern like the one Attachments use. The next change will use it to bulk-load custom field data.

Test Plan
  • Ran differential.query, differential.revision.search as a sanity check.
  • No behavioral changes are expected
  • See next revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39319.Jul 31 2016, 3:29 PM
epriestley retitled this revision from to Allow `*.search` Conduit API methods to have data bulk-loaded by extensions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
epriestley added a task: T11404: Improve the performance of custom field queries.
chad accepted this revision.Jul 31 2016, 3:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 31 2016, 3:37 PM
epriestley added a child revision: D16351: Improve Conduit performance for custom fields.Jul 31 2016, 3:46 PM
Closed by commit rP6e57582aff82: Allow `*.search` Conduit API methods to have data bulk-loaded by extensions (authored by epriestley, committed by epriestley). · Explain WhyJul 31 2016, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
query/
2 lines
policy/
engineextension/
2 lines
search/
engine/
16 lines
engineextension/
2 lines
6 lines
spaces/
engineextension/
2 lines
infrastructure/
customfield/
engineextension/
2 lines

Diff 39327

View Options

src/applications/conduit/query/ConduitResultSearchEngineExtension.php

Loading...
View Options

src/applications/policy/engineextension/PhabricatorPolicySearchEngineExtension.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorLiskSearchEngineExtension.php

Loading...
View Options

src/applications/search/engineextension/PhabricatorSearchEngineExtension.php

Loading...
View Options

src/applications/spaces/engineextension/PhabricatorSpacesSearchEngineExtension.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldSearchEngineExtension.php

Loading...
Phabricator · Built by Phacility